search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.31k forks source link

[14.1.X] add `ClusterShapeHitFilterESProducer_cfi` to `dedxEstimators_Cosmics_cff` as it's now requested by `DeDxHitInfoProducer` #46564

Open mmusich opened 17 hours ago

mmusich commented 17 hours ago

backport of https://github.com/cms-sw/cmssw/pull/46563

PR description:

Simple fix for https://github.com/cms-sw/cmssw/issues/46553

PR validation:

cmsRun DQM/Integration/python/clients/visualization-live-secondInstance_cfg.py runInputDir=/eos/user/d/dpapagia/data outputBaseDir=./output runNumber=387552 runkey=cosmic_run

runs fine (streamers courtesy of @nothingface0)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of https://github.com/cms-sw/cmssw/pull/46563 to CMSSW_14_1_X for 2024 HIon data-taking operations.

mmusich commented 17 hours ago

type bug-fix

cmsbuild commented 17 hours ago

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 17 hours ago

cms-bot internal usage

mmusich commented 17 hours ago

@cmsbuild, please test

mmusich commented 17 hours ago

urgent

nothingface0 commented 16 hours ago

Thanks, @mmusich ! From the DQM tests at P5, everything looks good.

jfernan2 commented 9 hours ago

+1

cmsbuild commented 9 hours ago

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild commented 8 hours ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b17b5a/42498/summary.html COMMIT: 7bf6e69746ef23bdbc7c6c75fb69f709ca976106 CMSSW: CMSSW_14_1_X_2024-10-31-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46564/42498/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary: