search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.31k forks source link

Phase2-hgx360D First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance #46565

Open bsunanda opened 15 hours ago

bsunanda commented 15 hours ago

PR description:

The first attempt to make a Phase2 scenario 2026D116 with no overlaps with zero tolerance

PR validation:

Tested using overlap checking tools present in SimG4Core/PrintGeomInfo. The number of overlaps is reduced from 348 to 38. The remaining overlaps are all in EB for reflected Solids

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild commented 15 hours ago

cms-bot internal usage

cmsbuild commented 15 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46565/42449

cmsbuild commented 15 hours ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

@Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @ptcox, @rovere, @sameasy, @slomeo, @vargasa, @watson-ij this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

kpedro88 commented 14 hours ago

@bsunanda can you add workflows for this new detector version in https://github.com/cms-sw/cmssw/blob/7dc755530ad751991ea10bacdc0dbaecff716186/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L90? Then we can test it directly in this PR.

bsunanda commented 14 hours ago

@kpedro88 OK I shall do that. I wanted to discuss on the remaining overlaps

bsunanda commented 14 hours ago

@cmsbuild Please test

cmsbuild commented 14 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46565/42451

cmsbuild commented 14 hours ago

Pull request #46565 was updated. @AdrianoDee, @Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @davidlange6, @dickychant, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please check and sign again.

bsunanda commented 14 hours ago

The new workflow is 32434.0

kpedro88 commented 13 hours ago

test parameters: workflow = 32434.0

kpedro88 commented 13 hours ago

please test

cmsbuild commented 9 hours ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 96KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-854d0e/42509/summary.html COMMIT: 7720d33a4e74b27f6b3898025b5c4d45fedc6c35 CMSSW: CMSSW_14_2_X_2024-10-30-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46565/42509/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

bsunanda commented 9 hours ago

@cmsbuild Please test

cmsbuild commented 6 hours ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-854d0e/42516/summary.html COMMIT: 7720d33a4e74b27f6b3898025b5c4d45fedc6c35 CMSSW: CMSSW_14_2_X_2024-10-30-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46565/42516/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

AdrianoDee commented 6 hours ago

please test with https://github.com/cms-sw/cmssw/pull/46559

cmsbuild commented 2 hours ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-854d0e/42522/summary.html COMMIT: 7720d33a4e74b27f6b3898025b5c4d45fedc6c35 CMSSW: CMSSW_14_2_X_2024-10-31-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46565/42522/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary: