Remove unused code from HeterogeneousCore/AlpakaCore

[fwyzard]

PR description:

Remove unused code from HeterogeneousCore/AlpakaCore.

PR validation:

All packages build and unit tests pass.

[fwyzard]

please test

[cmsbuild]

cms-bot internal usage

[fwyzard]

@makortel any objections to removing this ?

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46654/42575

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• HeterogeneousCore/AlpakaCore (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks. @makortel, @missirol, @rovere this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6021c2/42717/summary.html COMMIT: fcc9a51f27906264af99f48c4b1d2717dd8f6e65 CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46654/42717/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343588
• DQMHistoTests: Total failures: 364
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343204
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially removed 13 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 53031
• DQMHistoTests: Total failures: 51
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 52980
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 24 log files, 30 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[makortel]

@makortel any objections to removing this ?

I'm all for removing this unused piece that only creates confusion. Just for the record, the actually used logic for device selection is in https://github.com/cms-sw/cmssw/blob/cea249650467c0724ea7dadb238cef942570c708/HeterogeneousCore/AlpakaCore/src/alpaka/chooseDevice.cc#L8-L9

[fwyzard]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1