Fix BuildFiles, includes and comments

fwyzard commented 2 weeks ago

PR description:

Fix BuildFiles, includes and comments.

No changes expected.

PR validation:

None.

cmsbuild commented 2 weeks ago

cms-bot internal usage

fwyzard commented 2 weeks ago

please test

fwyzard commented 2 weeks ago

+heterogeneous

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46657/42577

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTracker/PixelSeeding/test/BuildFile.xml modified in PR(s): #45853

cmsbuild commented 2 weeks ago

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

DataFormats/Portable (heterogeneous)
RecoTracker/PixelSeeding (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 2 weeks ago

+1

Size: This PR adds an extra 28KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba0ea4/42723/summary.html COMMIT: a630ad2716fa0ef3bbf3f1d34c996c986ca40415 CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46657/42723/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3450336
DQMHistoTests: Total failures: 415
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3449901
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

jfernan2 commented 2 weeks ago

+1

cmsbuild commented 2 weeks ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1

cms-sw / cmssw