Phase2-hgx360J Add the dd4hep version of the modified code of passive material description of V19 geometry of HGCal

bsunanda commented 2 weeks ago

PR description:

Add the dd4hep version of the modified code of passive material description of V19 geometry of HGCal

PR validation:

Checked with materials from #46596

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild commented 2 weeks ago

cms-bot internal usage

cmsbuild commented 2 weeks ago

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46659/42581

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46659/42581/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46659/42581/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46659/42582

cmsbuild commented 2 weeks ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData (upgrade, geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda commented 1 week ago

@cmsbuild Please test

bsunanda commented 1 week ago

+geometry

bsunanda commented 1 week ago

@Moanwar, @srimanob, @subirsarkar Please approve this PR

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd2716/42746/summary.html COMMIT: 4154664bd18b130a837dc4842efb150d593fecd8 CMSSW: CMSSW_14_2_X_2024-11-11-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46659/42746/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343588
DQMHistoTests: Total failures: 428
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343140
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

subirsarkar commented 1 week ago

+Upgrade

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1

cms-sw / cmssw