cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

Phase2-hgx360k Update he name of the file dict2026geometry to dictRun4 in Geometry/CMSCommonData and Fireworks/Geometry #46661

Closed bsunanda closed 1 week ago

bsunanda commented 1 week ago

PR description:

Update he name of the file dict2026geometry to dictRun4 in Geometry/CMSCommonData and Fireworks/Geometry

PR validation:

Tested using the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46661/42583

cmsbuild commented 1 week ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

@Dr15Jones, @Moanwar, @alja, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @alja, @fabiocos, @martinamalberti, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda commented 1 week ago

@cmsbuild Please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cb7d4/42735/summary.html COMMIT: 9777cc8e6db2d0e2a9de7aae2846db4cb3847262 CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46661/42735/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

alja commented 1 week ago

+1

bsunanda commented 1 week ago

+geometry

bsunanda commented 1 week ago

@Moanwar, @srimanob, @subirsarkar Please approve this PR

Moanwar commented 1 week ago

+Upgrade

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1