search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

[Do not merge] Fix for asneeded IBs, force link pythia6/lhapdf libs #46665

Closed smuzaffar closed 1 week ago

smuzaffar commented 1 week ago

Some Relvals are failing in CMSSW_14_2_ASNEEDED_X IBs. Running these relfals locally print error like [a]. This PR makes sure that LHAPDF/pythia6 libs are linked and loaded at runtime. These libs provide the PDFSET symbol.

explicitly linking the Pyquen/Hydjet/Pythia6 allowed to run all the failing workflows

1143.201_HydjetQ_B12_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:26:24 2024-date Tue Nov 12 11:23:03 2024; exit: 0 0 0 0
143.202_HydjetQ_MinBias_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Tue Nov 12 11:26:27 2024-date Tue Nov 12 11:23:03 2024; exit: 0 0 0 0 0
148.0_HydjetQ_MinBias_XeXe_5442GeV_2017 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:26:20 2024-date Tue Nov 12 11:23:04 2024; exit: 0 0 0 0
43.201_HydjetQ_B12_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:26:24 2024-date Tue Nov 12 11:23:03 2024; exit: 0 0 0 0
331.0_Pyquen_DiJet_pt80to120_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:31:37 2024-date Tue Nov 12 11:26:43 2024; exit: 0 0 0 0
332.0_Pyquen_ZeemumuJets_pt10_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:31:21 2024-date Tue Nov 12 11:26:47 2024; exit: 0 0 0 0
574.0_HydjetQ_B12_5020GeV_2018_ExtGen Step0-PASSED Step1-PASSED  - time date Tue Nov 12 11:27:26 2024-date Tue Nov 12 11:26:51 2024; exit: 0 0
577.0_Pyquen_ZeemumuJets_pt10_2760GeV_ExtGen Step0-PASSED Step1-PASSED  - time date Tue Nov 12 11:27:20 2024-date Tue Nov 12 11:26:54 2024; exit: 0 0
29 29 27 26 12 3 tests passed, 0 0 0 0 0 0 failed

[a]

1****************** PYINIT: initialization of PYTHIA routines *****************
 Error: you did not link PDFLIB correctly.
 Dummy routine PDFSET in PYTHIA file called instead.
 Execution stopped!

     PYSTOP called with code:    5
cmsbuild commented 1 week ago

cms-bot internal usage

smuzaffar commented 1 week ago

test parameters:

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46665/42592

cmsbuild commented 1 week ago

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar commented 1 week ago

please test for CMSSW_14_2_ASNEEDED_X

cmsbuild commented 1 week ago

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42745/summary.html COMMIT: 5295f9d6fda2d4d8cced317111ca61596226410d CMSSW: CMSSW_14_2_ASNEEDED_X_2024-11-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46665/42745/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42745/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42745/git-merge-result

RelVals

smuzaffar commented 1 week ago

ok, this change fixed the workflow 132.0 , looks like other generator interface also need such a change e.g. workflow 312.0 is failing as GeneratorInterface/PyquenInterface is missing to link pdfset

smuzaffar commented 1 week ago

please test for CMSSW_14_2_ASNEEDED_X

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46665/42600

cmsbuild commented 1 week ago

Pull request #46665 was updated. @bbilin, @lviliani, @menglu21, @mkirsano can you please check and sign again.

cmsbuild commented 1 week ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42757/summary.html COMMIT: 066b0ea4cd5aaa040bbe1a2b481a6b8f1182f6c6 CMSSW: CMSSW_14_2_ASNEEDED_X_2024-11-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46665/42757/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42757/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42757/git-merge-result

Comparison Summary

Summary: