search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

[14.1.X] fix HLT online DQM client to cope with PbPb HLT strip collections #46667

Closed mmusich closed 1 week ago

mmusich commented 1 week ago

backport of https://github.com/cms-sw/cmssw/pull/46622

PR description:

Title says it all, aimed to fix the empty Strip collections at HLT seen in the early 2024 PbPb runs, e.g. 387886 (link to DQM)

PR validation:

See See https://github.com/cms-sw/cmssw/pull/46622#issuecomment-2466418452.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of https://github.com/cms-sw/cmssw/pull/46622 to the 2024 PbPb data-taking cycle.

cmsbuild commented 1 week ago

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @rseidita can you please review it and eventually sign? Thanks. @Fedespring, @HuguesBrun, @batinkov, @cericeci, @francescobrivio, @jhgoh, @missirol, @mtosi, @rociovilar, @silviodonato, @threus, @trocino this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 1 week ago

cms-bot internal usage

mmusich commented 1 week ago

@cmsbuild, please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-311a28/42750/summary.html COMMIT: 2f7cf2c801d4ecd684cb04151c152dc1ef58d949 CMSSW: CMSSW_14_1_X_2024-11-11-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46667/42750/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

antoniovagnerini commented 1 week ago

+1

mmusich commented 1 week ago

+hlt

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1