cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

[BTV,DQM] Expand MiniAOD input DQM and Validations plots with latest taggers, switch to slimmedJetsPuppi #46674

Closed nurfikri89 closed 2 days ago

nurfikri89 commented 1 week ago

PR description:

This PR expands the BTV DQM & Validation plots by adding ParticleNet and UParT taggers that are stored in MiniAOD. The jet collection has changed to AK4 Puppi jets (slimmedJetsPuppi). The working point cut values updated to Summer23BPix campaign. Removed a few files and consolidated their contents into a single file.

PR validation:

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46674/42596

cmsbuild commented 1 week ago

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. @AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @rociovilar this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

antoniovagnerini commented 1 week ago

please test

cmsbuild commented 1 week ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42759/summary.html COMMIT: 046c953bf35075b98173ad67ae28fb54746f6022 CMSSW: CMSSW_14_2_X_2024-11-11-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42759/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

nurfikri89 commented 1 week ago

Unit test fail due to this #46682?

antoniovagnerini commented 1 week ago

please test

antoniovagnerini commented 1 week ago

Unit test fail due to this #46682?

yes but it should be fixed now

cmsbuild commented 1 week ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42834/summary.html COMMIT: 046c953bf35075b98173ad67ae28fb54746f6022 CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42834/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS
---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

smuzaffar commented 1 week ago

please test

cmsbuild commented 1 week ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42850/summary.html COMMIT: 046c953bf35075b98173ad67ae28fb54746f6022 CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42850/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

antoniovagnerini commented 4 days ago

please test

cmsbuild commented 4 days ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42920/summary.html COMMIT: 046c953bf35075b98173ad67ae28fb54746f6022 CMSSW: CMSSW_14_2_X_2024-11-17-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46674/42920/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

antoniovagnerini commented 4 days ago

please test

cmsbuild commented 3 days ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42935/summary.html COMMIT: 046c953bf35075b98173ad67ae28fb54746f6022 CMSSW: CMSSW_14_2_X_2024-11-18-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46674/42935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

antoniovagnerini commented 3 days ago

+1

cmsbuild commented 3 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 2 days ago

+1