cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

[SIM] Fixed compilation warning with the new Geant4 11.3 #46675

Closed civanch closed 1 week ago

civanch commented 1 week ago

PR description:

There is the compilation warning with the new Geant4 11.3. This fix is also useful for previous Geant4 version. No change in any WF is expected.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46675/42597

cmsbuild commented 1 week ago

A new Pull Request was created by @civanch for master.

It involves the following packages:

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. @bsunanda, @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar commented 1 week ago

please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc8cf7/42761/summary.html COMMIT: 60a181e1ce0b87304c5c53ffb054de0605c1054c CMSSW: CMSSW_14_2_X_2024-11-11-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46675/42761/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

civanch commented 1 week ago

+1

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

civanch commented 1 week ago

urgent

civanch commented 1 week ago

@antoniovilela , @mandrenguyen , this PR is very simple but is needed urgently for testing of the new Geant4.

mandrenguyen commented 1 week ago

+1