search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

Add time to HGCAL CaloParticles #46678

Open AuroraPerego opened 1 week ago

AuroraPerego commented 1 week ago

PR description:

Following the MtdTruthAccumulator.cc logic, the SimVertex time has also been added to the HGCAL CaloParticles. This is needed because the information coming from the SimVertexCollection of the CaloParticles from pileup is lost if not saved in the CaloTruthAccumulator.cc. The name of the method used to assign the time has been changed to the more appropriate setSimTime. The correction of the time for oot pileup has been removed since the SimVertex time takes that already into account.

PR validation:

Tested on wfs 29888.203 (classical mixing) and 29888.99 (premix) enabling the CaloParticles from pileup (they are disabled by default). Example to test it:

test parameters:
    - workflow_opts= -w upgrade
    - workflow = 29888.99,29888.203

FYI @waredjeb @felicepantaleo @rovere

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46678/42605

cmsbuild commented 1 week ago

A new Pull Request was created by @AuroraPerego for master.

It involves the following packages:

@Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @ReyerBand, @apsallid, @bsunanda, @fabiocos, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @makortel, @martinamalberti, @missirol, @mmusich, @rovere, @sameasy, @slomeo, @sobhatta, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

fwyzard commented 1 week ago

allow @AuroraPerego test rights

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46678/42615

cmsbuild commented 1 week ago

Pull request #46678 was updated. @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46678/42616

cmsbuild commented 1 week ago

Pull request #46678 was updated. @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

AuroraPerego commented 1 week ago

test parameters:

AuroraPerego commented 1 week ago

please test

cmsbuild commented 1 week ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 44KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf614f/42773/summary.html COMMIT: 20c4dab8191da9a11274caa75696a71294648663 CMSSW: CMSSW_14_2_X_2024-11-12-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46678/42773/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline: 2024.101001 step 1 2024.202001 step 1 2024.303001 step 1 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46678/42631

cmsbuild commented 1 week ago

Pull request #46678 was updated. @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

AuroraPerego commented 1 week ago

please test

cmsbuild commented 1 week ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 44KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf614f/42803/summary.html COMMIT: c51fc8558915f1ed1f031bb4e43a043624ef615b CMSSW: CMSSW_14_2_X_2024-11-12-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46678/42803/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

AuroraPerego commented 5 days ago

please test

cmsbuild commented 5 days ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf614f/42903/summary.html COMMIT: c51fc8558915f1ed1f031bb4e43a043624ef615b CMSSW: CMSSW_14_2_X_2024-11-16-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46678/42903/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

felicepantaleo commented 1 day ago

ignore tests-rejected with ib-failure

civanch commented 1 day ago

+1

jfernan2 commented 1 day ago

+1

cmsbuild commented 1 hour ago

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.