explicitly link pythia6_pdfdummy where needed

smuzaffar commented 1 week ago

This change along with https://github.com/cms-sw/cmsdist/pull/9514 should properly link lhapdf library for ASNEEDED IBs. Currently pythia6 tool also link pythia6_pdfdummy library which provides the pdfset symbol. For ASNEEDED IBs, complier decided to not link lhapdf as the needed pdfset symbol was available via pythia6_pdfdummy. cmsdist PR moves pythia6_pdfdummy in to a separate tool file which is then only linked where it is needed.

Fixes #45747

cmsbuild commented 1 week ago

cms-bot internal usage

smuzaffar commented 1 week ago

test parameters:

pull_request = cms-sw/cmsdist#9514
full_cmssw = true
workflows = 132.0,143.201,143.202,148.0,158.0,159.0,159.02,159.03,160.0,160.02,160.03,160.501,161.0,161.02,161.03,300.0,301.0,302.0,310.0,311.0,312.0,320.0,321.0,322.0,330.0,331.0,332.0,574.0,577.0

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46684/42624

cmsbuild commented 1 week ago

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

GeneratorInterface/GenExtensions (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar commented 1 week ago

please test

smuzaffar commented 1 week ago

please test

smuzaffar commented 1 week ago

please test for CMSSW_14_2_ASNEEDED_X

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42793/summary.html COMMIT: 363de6544b1c9e1a28479bb2e4a278f34ab72b4f CMSSW: CMSSW_14_2_X_2024-11-12-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46684/42793/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 10 lines to the logs
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 5726165
DQMHistoTests: Total failures: 428
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 5725717
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 68 files compared)
Checked 324 log files, 287 edm output root files, 69 DQM output files
TriggerResults: no differences found

cmsbuild commented 1 week ago

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42798/summary.html COMMIT: 363de6544b1c9e1a28479bb2e4a278f34ab72b4f CMSSW: CMSSW_14_2_ASNEEDED_X_2024-11-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46684/42798/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@slomeo cms-sw/cmssw#46646
@bsunanda cms-sw/cmssw#46626
@CMS-LUMI-POG cms-sw/cmssw#46557
@mroguljic cms-sw/cmssw#46392
@iarspider cms-sw/cmssw#46635
@AdrianoDee cms-sw/cmssw#46636
@aloeliger cms-sw/cmssw#46303
@perrotta cms-sw/cmssw#46644
@bsunanda cms-sw/cmssw#46570
@perrotta cms-sw/cmssw#46671
@bsunanda cms-sw/cmssw#46596
@ashleyahram cms-sw/cmssw#46639

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42798/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42798/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

You potentially added 202 lines to the logs
Reco comparison results: 2612 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 5726165
DQMHistoTests: Total failures: 2277
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 5723868
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 68 files compared)
Checked 324 log files, 287 edm output root files, 69 DQM output files
TriggerResults: no differences found

smuzaffar commented 1 week ago

please test for CMSSW_14_2_ASNEEDED_X

lets test full cmssw ( i.e all unit tests)

cmsbuild commented 1 week ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42815/summary.html COMMIT: 363de6544b1c9e1a28479bb2e4a278f34ab72b4f CMSSW: CMSSW_14_2_ASNEEDED_X_2024-11-13-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46684/42815/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@mmusich cms-sw/cmssw#46622
@yeckang cms-sw/cmssw#46620
@bsunanda cms-sw/cmssw#46626
@Dr15Jones cms-sw/cmssw#46603
@AdrianoDee cms-sw/cmssw#46686
@bsunanda cms-sw/cmssw#46681
@woohyeonHeo cms-sw/cmssw#46653
@mbluj cms-sw/cmssw#46679
@felicepantaleo cms-sw/cmssw#46651
@Dr15Jones cms-sw/cmssw#46630
@fwyzard cms-sw/cmssw#46657
@fwyzard cms-sw/cmssw#46654
@bsunanda cms-sw/cmssw#46670
@bsunanda cms-sw/cmssw#46659
@civanch cms-sw/cmssw#46675
@nurfikri89 cms-sw/cmssw#46676
@bsunanda cms-sw/cmssw#46677
@jonathon-langford cms-sw/cmssw#46343
@mroguljic cms-sw/cmssw#46392
@mmusich cms-sw/cmssw#46645
@mmusich cms-sw/cmssw#46647
@bsunanda cms-sw/cmssw#46648
@bsunanda cms-sw/cmssw#46596
@bsunanda cms-sw/cmssw#46661

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42815/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42815/git-merge-result

Comparison Summary

Summary:

You potentially removed 123 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 643 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 5726165
DQMHistoTests: Total failures: 3631
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 5722514
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 37.138 KiB( 68 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 2.531 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): 1.689 KiB Physics/NanoAODDQM
Checked 324 log files, 287 edm output root files, 69 DQM output files
TriggerResults: no differences found

smuzaffar commented 1 week ago

@cms-sw/generators-l2 can you please review and sign this PR? This is just a technical update which will allow us to enable --as-needed link flag for cmssw

lviliani commented 1 week ago

+1

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9514

cmsbuild commented 1 week ago

REMINDER @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio: This PR was tested with cms-sw/cmsdist#9514, please check if they should be merged together

mandrenguyen commented 1 week ago

+1

cms-sw / cmssw