search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

[14_1_X] Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond #46685

Open stahlleiton opened 1 week ago

stahlleiton commented 1 week ago

PR description:

Backport of https://github.com/cms-sw/cmssw/pull/46562

The data and HI MC Gts are updated in autoCond to take the new regressions into account:

@mandrenguyen

cmsbuild commented 1 week ago

A new Pull Request was created by @stahlleiton for CMSSW_14_1_X.

It involves the following packages:

@AdrianoDee, @Moanwar, @atpathak, @cmsbuild, @consuegs, @dickychant, @jfernan2, @mandrenguyen, @miquork, @perrotta, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @argiro, @fabiocos, @jainshilpi, @lgray, @makortel, @missirol, @mmusich, @ram1123, @rchatter, @rovere, @rsreds, @sameasy, @slomeo, @sobhatta, @thomreis, @tocheng, @valsdav, @varuns23, @wang0jin, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 1 week ago

cms-bot internal usage

mandrenguyen commented 1 week ago

backport of https://github.com/cms-sw/cmssw/pull/46562

mandrenguyen commented 1 week ago

please test workflows 180,180.1,181,181.1,141.901,141.902,142.0,142.901,142.902,142.903

cmsbuild commented 1 week ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ac88e/42810/summary.html COMMIT: fafe2a4aab7cf8f72f6445b0d122680daf4032f8 CMSSW: CMSSW_14_1_X_2024-11-13-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46685/42810/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMOnlineClient-visualization_secondInstance had ERRORS
---> test TestDQMOnlineClient-visualization had ERRORS

Comparison Summary

Summary:

stahlleiton commented 1 week ago

Is the error in the tests related to this PR?

cmsbuild commented 1 week ago

Pull request #46685 was updated. @AdrianoDee, @Moanwar, @atpathak, @cmsbuild, @consuegs, @dickychant, @jfernan2, @mandrenguyen, @miquork, @perrotta, @srimanob, @subirsarkar can you please check and sign again.

stahlleiton commented 1 week ago

@perrotta : Fixed the merge conflicts with the Alca PR that got recently merged.

AdrianoDee commented 1 week ago

please test

AdrianoDee commented 1 week ago

please abort

AdrianoDee commented 1 week ago

please test workflows 180,180.1,181,181.1,141.901,141.902,142.0,142.901,142.902,142.903

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ac88e/42829/summary.html COMMIT: 2c6c8980b03f9e4b5e30a9d63c76c120ea8f5ba5 CMSSW: CMSSW_14_1_X_2024-11-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46685/42829/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

AdrianoDee commented 1 week ago

+pdmv

Moanwar commented 1 week ago

+Upgrade

jfernan2 commented 1 week ago

+1

cmsbuild commented 1 week ago

Pull request #46685 was updated. @AdrianoDee, @Moanwar, @atpathak, @cmsbuild, @consuegs, @dickychant, @jfernan2, @mandrenguyen, @miquork, @perrotta, @srimanob, @subirsarkar can you please check and sign again.

perrotta commented 6 days ago

please test workflows 180,180.1,181,181.1,141.901,141.902,142.0,142.901,142.902,142.903

perrotta commented 6 days ago

@stahlleiton please take care of https://github.com/cms-sw/cmssw/pull/46562#issuecomment-2480481096 also in this backport

stahlleiton commented 6 days ago

@stahlleiton please take care of #46562 (comment) also in this backport

@perrotta : done, the PR title and description has been updated.

cmsbuild commented 6 days ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ac88e/42898/summary.html COMMIT: 1846c3361c3a3f0146f9909ee15e6291d214c3bd CMSSW: CMSSW_14_1_X_2024-11-15-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46685/42898/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

jfernan2 commented 4 days ago

+1

Moanwar commented 4 days ago

+Upgrade

stahlleiton commented 3 days ago

@cms-sw/alca-l2 , @cms-sw/pdmv-l2 : please review/sign this PR , thanks

AdrianoDee commented 3 days ago

+pdmv

perrotta commented 2 days ago

+alca

cmsbuild commented 2 days ago

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)