search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Phase2-hgx360O Replace 2026 wth Run4 in some scripts of Alignment/MillePedeAlignmentAlgorithm and CalibCalorimetry/EBPhase2TPGTools #46689

Closed bsunanda closed 1 week ago

bsunanda commented 1 week ago

PR description:

Replace 2026 wth Run4 in some scripts of Alignment/MillePedeAlignmentAlgorithm and CalibCalorimetry/EBPhase2TPGTools

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46689/42628

cmsbuild commented 1 week ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @perrotta can you please review it and eventually sign? Thanks. @adewit, @mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda commented 1 week ago

@cmsbuild Please test

cmsbuild commented 1 week ago

-1

Failed Tests: RelVals Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-775d1c/42796/summary.html COMMIT: d3d6c64dc9f8c3be484c783594b5d2f18e5696e1 CMSSW: CMSSW_14_2_X_2024-11-12-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46689/42796/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

bsunanda commented 1 week ago

@cmsbuild Please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-775d1c/42805/summary.html COMMIT: d3d6c64dc9f8c3be484c783594b5d2f18e5696e1 CMSSW: CMSSW_14_2_X_2024-11-13-1300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46689/42805/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

perrotta commented 1 week ago

+alca

aloeliger commented 1 week ago

+l1

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1