cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

[DQM] Modify DQMGUI upload test to only run in automated environments #46690

Closed nothingface0 closed 1 week ago

nothingface0 commented 1 week ago

PR description:

After @smuzaffar's recommendation, modify TestDQMGUIUpload to only run for PRs and IBs, and not for local testing, when the DQMServices/Demo package is checked out. The test checks for the CMSBOT_CI_TESTS env var, or a --force argument, to override the variable.

Also fix the timestamp of the renamed file to include the hour, which was missing before, it will help with debugging.

A --help argument to print the script's usage is also added.

See also: #46682

PR validation:

Tested on LXPLUS. DQMGUI dev is currently unavailable for full testing.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46690/42630

cmsbuild commented 1 week ago

A new Pull Request was created by @nothingface0 for master.

It involves the following packages:

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. @barvic this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

rseidita commented 1 week ago

please test

rseidita commented 1 week ago

@cmsbuild please abort

Didn't notice the "DQMGUI dev not available" part

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46690/42632

cmsbuild commented 1 week ago

Pull request #46690 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46690/42633

cmsbuild commented 1 week ago

Pull request #46690 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

nothingface0 commented 1 week ago

@rseidita you can trigger the tests again

smuzaffar commented 1 week ago

please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2360f2/42816/summary.html COMMIT: fdd94e8a6290f3103b9980c5ce675ae4a2f20198 CMSSW: CMSSW_14_2_X_2024-11-13-1300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46690/42816/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

antoniovagnerini commented 1 week ago

+1

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1