search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Phase2-hgx360Q Correct the passive absorber description and add the cooling petal for HGCal EE detector #46699

Closed bsunanda closed 1 week ago

bsunanda commented 1 week ago

PR description:

Correct the passive absorber description and add the cooling petal for HGCal EE detector

PR validation:

Test using fireworks

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46699/42645

cmsbuild commented 1 week ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda commented 1 week ago

@cmsbuild Please test

cmsbuild commented 1 week ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 28KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9cc8/42847/summary.html COMMIT: 0d461cc5bc8689835153b46620b71511209a0c7b CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46699/42847/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

bsunanda commented 1 week ago

@cmsbuild Please test

cmsbuild commented 1 week ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9cc8/42857/summary.html COMMIT: 0d461cc5bc8689835153b46620b71511209a0c7b CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46699/42857/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

bsunanda commented 1 week ago

@cmsbuild Please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9cc8/42870/summary.html COMMIT: 0d461cc5bc8689835153b46620b71511209a0c7b CMSSW: CMSSW_14_2_X_2024-11-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46699/42870/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

bsunanda commented 1 week ago

+geometry

bsunanda commented 1 week ago

@Moanwar, @subirsarkar Please approve this

subirsarkar commented 1 week ago

+Upgrade

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1