search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

Fix `base_wf_number_2022` (should be `base_wf`) #46701

Closed AdrianoDee closed 5 days ago

AdrianoDee commented 1 week ago

PR description:

Small fix prompted by https://github.com/cms-sw/cmssw/pull/46610#issuecomment-2476858257.

AdrianoDee commented 1 week ago

type bug-fix

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46701/42650

cmsbuild commented 1 week ago

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

@AdrianoDee, @Moanwar, @cmsbuild, @dickychant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee commented 1 week ago

test parameters:

AdrianoDee commented 1 week ago

please test

cmsbuild commented 1 week ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0be0a/42858/summary.html COMMIT: 912937b47f651b1f12b4a64619819b0dedf0f9e9 CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46701/42858/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-runTheMatrix-interactive had ERRORS

Comparison Summary

Summary:

AdrianoDee commented 1 week ago

please test

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46701/42657

cmsbuild commented 1 week ago

Pull request #46701 was updated. @AdrianoDee, @Moanwar, @dickychant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0be0a/42867/summary.html COMMIT: b4be55d6a25ee39f833f37e9e5aed877ebf79790 CMSSW: CMSSW_14_2_X_2024-11-14-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46701/42867/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

AdrianoDee commented 1 week ago

+pdmv

AdrianoDee commented 1 week ago

@cms-sw/upgrade-l2 sorry to bother, if you could have a look at this I would like to try to have this included before pre4 is closed ( if @cms-sw/orp-l2 agree ).

Moanwar commented 1 week ago

+Upgrade

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

AdrianoDee commented 1 week ago

Thanks @Moanwar !

smuzaffar commented 1 week ago

@AdrianoDee , for relvals_opt (under test parameters ) one needs to provide the workflow/relval number too. I suggest to restart the tests by add relvals = <wf_num> in https://github.com/cms-sw/cmssw/pull/46701#issuecomment-2476879707

AdrianoDee commented 1 week ago

@smuzaffar in this specific case I didn't really wanted to test any wf but just check that the matrix tests were not failing anymore with

ignoring non-requested file relval_premix
ignoring non-requested file relval_nano
processing relval_data_highstats
ERROR importing file  relval_data_highstats name 'base_wf_number_2022' is not defined
ignoring non-requested file relval_standard

and they don't

ignoring non-requested file relval_premix
ignoring non-requested file relval_nano
processing relval_data_highstats
ignoring non-requested file relval_standard
ignoring non-requested file relval_highstats

I'll resend them with a dummy wf.

AdrianoDee commented 1 week ago

test parameters:

AdrianoDee commented 1 week ago

please test

cmsbuild commented 6 days ago

-1

Failed Tests: RelVals Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0be0a/42883/summary.html COMMIT: b4be55d6a25ee39f833f37e9e5aed877ebf79790 CMSSW: CMSSW_14_2_X_2024-11-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46701/42883/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 2024.101001

AdrianoDee commented 6 days ago

test parameters:

AdrianoDee commented 6 days ago

please test

cmsbuild commented 6 days ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0be0a/42888/summary.html COMMIT: b4be55d6a25ee39f833f37e9e5aed877ebf79790 CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46701/42888/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

mandrenguyen commented 5 days ago

+1