add profiles of vertex track impact parameters and IP errors vs track pT in `PrimaryVertexMonitor`

mmusich commented 1 week ago

PR description:

Title says it all, add more diagnostics as a function of the track transverse momentum.

PR validation:

Run successfully: runTheMatrix.py -l 2024.202001 -t 4 -j 8 --ibeos --nEvents=500 and observed new MonitorElements begin filled.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46704/42658

cmsbuild commented 1 week ago

A new Pull Request was created by @mmusich for master.

It involves the following packages:

DQMOffline/RecoB (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. @AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @rociovilar this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich commented 1 week ago

@cmsbuild, please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bf68c/42869/summary.html COMMIT: 8cf0863dfe99a9bdaa05caee2a7bfe8be1f124b3 CMSSW: CMSSW_14_2_X_2024-11-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46704/42869/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3450524
DQMHistoTests: Total failures: 386
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3450118
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 243.1440000000001 KiB( 46 files compared)
DQMHistoSizes: changed ( 12434.7,... ): 3.668 KiB OfflinePV/Alignment
DQMHistoSizes: changed ( 16834.0,... ): 11.646 KiB HLT/Vertexing
DQMHistoSizes: changed ( 24834.911,... ): 7.696 KiB HLT/Vertexing
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

antoniovagnerini commented 6 days ago

+1

spurious differences from HGCal DQM test (open issue #46416)

cmsbuild commented 6 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 6 days ago

+1

cms-sw / cmssw