Run3-hcx379 First version of 2025 scenario - still needed the correct PPS geometry with the needed rotation

bsunanda commented 1 week ago

PR description:

First version of 2025 scenario - still needed the correct PPS geometry with the needed rotation

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for

Backported to 14_2_X as #46785 along with #46784

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46705/42659

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/README.md modified in PR(s): #46610
- File Configuration/StandardSequences/python/GeometryConf.py modified in PR(s): #46610

cmsbuild commented 1 week ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry (geometry, upgrade)
Configuration/StandardSequences (operations)
Geometry/CMSCommonData (geometry, upgrade)

@Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo, @vargasa this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda commented 1 week ago

@cmsbuild Please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dee15e/42896/summary.html COMMIT: 74ae9ff90eaced1d8121515569e5d2ac271dd9f9 CMSSW: CMSSW_14_2_X_2024-11-15-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46705/42896/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343764
DQMHistoTests: Total failures: 543
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343201
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

civanch commented 1 week ago

@fabferro , only PPS is absent in the new geometry configuration.

civanch commented 1 week ago

+1

bsunanda commented 1 week ago

@Moanwar, @subirsarkar Please approve this PR

subirsarkar commented 1 week ago

+Upgrade

fabferro commented 1 week ago

PPS geometry will come later. A final decision about it has not yet been taken

bsunanda commented 4 days ago

@antoniovilela, @mandrenguyen, Please approve and merge this PR

srimanob commented 4 days ago

Hi,

This PR is done more than that, even no effect. I think it should be mentioned clearly to avoid confusion. (1) This PR renames M3 (which does not use at the moment) to M4, and move gem21/2024/v2/gem21.xml to new M4. So new M4 = old M4, just remove unused M3 (2) Add M5 for 2025.

bsunanda commented 4 days ago

Please merge this PR and I shall try to get the new 2025 geometry along with modified 2021, 2023, 2024 parts

bsunanda commented 4 days ago

@antoniovilela, @mandrenguyen, @srimanob Please approve and merge this PR. I cannot proceed unless this PR is merged

bsunanda commented 3 days ago

@antoniovilela, @mandrenguyen, @srimanob Please merge this version - I have to include the changes for the muon section as proposed by the DT team. I shall update M3 for 2024 M4 for 2025. I need this to be included in IB urgently

cmsbuild commented 3 days ago

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

bsunanda commented 3 days ago

@antoniovilela, @mandrenguyen, @srimanob Please merge this version - I have to include the changes for the muon section as proposed by the DT team. I shall update M3 for 2024 M4 for 2025. I need this to be included in IB urgently. It has to be backported to 14_2_X once the corrections are included as well

mandrenguyen commented 3 days ago

+1

cmsbuild commented 3 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cms-sw / cmssw