Drop histbook unittest: package is unmaintained - Githubissues

cms-sw / cmssw

CMS Offline Software

http://cms-sw.github.io/

Apache License 2.0

1.09k stars 4.33k forks source link

Drop histbook unittest: package is unmaintained #46706

Closed smuzaffar closed 1 week ago

smuzaffar commented 1 week ago

Drop unit tests for histbook python package. This does not work for newer python versions (e.g. python 3.12) and package has not released any new version since 2018.

smuzaffar commented 1 week ago

please test

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46706/42660

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PythonAnalysis/test/BuildFile.xml modified in PR(s): #45441

cmsbuild commented 1 week ago

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

PhysicsTools/PythonAnalysis (analysis)

@tvami can you please review it and eventually sign? Thanks. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4e1eb/42873/summary.html COMMIT: 4d6e17d4ef71db1ea70c6f0cdf7a2654684314e5 CMSSW: CMSSW_14_2_X_2024-11-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46706/42873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343764
DQMHistoTests: Total failures: 377
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343367
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

cmsbuild commented 1 week ago

REMINDER @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio: This PR was tested with cms-sw/cmsdist#9517, please check if they should be merged together

tvami commented 1 week ago

+1

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1