search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

[Py312] Move away from using imp python module #46707

Open smuzaffar opened 1 week ago

smuzaffar commented 1 week ago

imp moduleis deprecated since python 3.4 and has been removed from python 3.12. The unit test here is only using imp.find_module to find the path of python module. This can be easily achieved by using importlib.machinery.PathFinder.find_spec().origin.

smuzaffar commented 1 week ago

please test

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46707/42664

cmsbuild commented 1 week ago

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. @makortel, @missirol, @wddgit this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66f70b/42879/summary.html COMMIT: 0d92ca221ffd988a6e471a00e779f51f6118cd69 CMSSW: CMSSW_14_2_X_2024-11-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46707/42879/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

smuzaffar commented 7 hours ago

@makortel , any objection on this change ?

cmsbuild commented 2 hours ago

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

makortel commented 42 minutes ago

+core

cmsbuild commented 41 minutes ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)