search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

Remove redefinition of EDM_ML_DEBUG in HcalDigitizer.cc #46708

Closed iarspider closed 5 days ago

iarspider commented 1 week ago

PR description:

Title says it all.

PR validation:

Bot tests

iarspider commented 1 week ago

please test for CMSSW_14_2_DBG_X

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46708/42665

cmsbuild commented 1 week ago

A new Pull Request was created by @iarspider for master.

It involves the following packages:

@civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. @abdoulline, @bsunanda, @mariadalfonso, @rovere, @sameasy this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

civanch commented 6 days ago

+1

the fix is obvious, should not affect any test

cmsbuild commented 6 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

civanch commented 6 days ago

urgent

cmsbuild commented 6 days ago

-1

Failed Tests: UnitTests RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/summary.html COMMIT: b56a39429be0ef648db27964e7446132d04d92f2 CMSSW: CMSSW_14_2_DBG_X_2024-11-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS
---> test test_MC_22_crosscheck had ERRORS

RelVals

At: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc

(2): ----- End Fatal Exception ------------------------------------------------- ``` - [29700.0](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/runTheMatrix-results/29700.0_CloseByPGun_CE_H_Coarse_Scint+Run4D110) ``` ----- Begin Fatal Exception 15-Nov-2024 14:52:29 CET----------------------- An exception of category 'ConfigFileReadError' occurred while [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py Exception Message: unknown python problem occurred. RuntimeError: An exception of category 'FileInPathError' occurred. Exception Message: edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29700.0_CloseByPGun_CE_H_Coarse_Scint+Run4D110 At: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc (2): ----- End Fatal Exception ------------------------------------------------- ``` - [29634.75](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/runTheMatrix-results/29634.75_TTbar_14TeV+Run4D110_HLT75e33Timing) ``` ----- Begin Fatal Exception 15-Nov-2024 18:15:56 CET----------------------- An exception of category 'ConfigFileReadError' occurred while [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py Exception Message: unknown python problem occurred. RuntimeError: An exception of category 'FileInPathError' occurred. Exception Message: edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29634.75_TTbar_14TeV+Run4D110_HLT75e33Timing At: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc (2): ----- End Fatal Exception ------------------------------------------------- ```
Expand to see more relval errors ... - [29634.0](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/runTheMatrix-results/29634.0_TTbar_14TeV+Run4D110) - [24834.911](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/runTheMatrix-results/24834.911_TTbar_14TeV+Run4D98_DD4hep) - [29634.911](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/runTheMatrix-results/29634.911_TTbar_14TeV+Run4D110_DD4hep) - [29834.999](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/runTheMatrix-results/29834.999_TTbar_14TeV+Run4D110PU_PMXS1S2PR)
civanch commented 6 days ago

Do not know what happens in testing but not related to this PR.

civanch commented 6 days ago

please test

cmsbuild commented 6 days ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42899/summary.html COMMIT: b56a39429be0ef648db27964e7446132d04d92f2 CMSSW: CMSSW_14_2_X_2024-11-16-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42899/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

mandrenguyen commented 5 days ago

+1