cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

Fix mask production for empty seeding region #46709

Closed felicepantaleo closed 5 days ago

felicepantaleo commented 1 week ago

This PR fixes https://github.com/cms-sw/cmssw/issues/46698 for wf with HFNose in the Geometry.

cmsbuild commented 1 week ago

cms-bot internal usage

felicepantaleo commented 1 week ago

test parameters:

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46709/42666

cmsbuild commented 1 week ago

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @apsallid, @forthommel, @hatakeyamak, @lecriste, @missirol, @rovere, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

felicepantaleo commented 1 week ago

@cmsbuild please test

jfernan2 commented 6 days ago

fixes https://github.com/cms-sw/cmssw/issues/46698

cmsbuild commented 6 days ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6371ae/42882/summary.html COMMIT: 6c65e586b2246ae50ed47ed909437a5049eead50 CMSSW: CMSSW_14_2_X_2024-11-14-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46709/42882/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline: 32034.0 step 3 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

jfernan2 commented 6 days ago

+1

Moanwar commented 6 days ago

+Upgrade

cmsbuild commented 6 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 5 days ago

+1