Noisy_ElectronSeedProducer_Correction_V1 : plugins part

[archiron]

PR description:

Finish the transition from infinity() to max() Description: Solves the problem reported here. The printouts were triggered because a mixed usage of max() and infinity()

PR validation:

compilation is OK, basics tests (scram b runtests or local tests) are OK too. runTheMatrix.py -l limited -i all --ibeos tests are fine 41 40 39 34 17 1 1 1 1 1 1 tests passed, 2 0 0 0 0 0 0 0 0 0 0 failed the 2 errors are DAS error (see runall-report-step123-.log). runall-report-step123-.logation is OK, basics tests (scram b runtests or local tests) are OK too. runall-report-step123-.log

@beaudett

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46710/42668

[cmsbuild]

A new Pull Request was created by @archiron for master.

It involves the following packages:

• DataFormats/EgammaReco (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @Prasant1993, @Sam-Harper, @a-kapoor, @afiqaize, @jainshilpi, @lgray, @missirol, @mmusich, @rovere, @sameasy, @sobhatta, @varuns23 this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a7fa3/42886/summary.html COMMIT: b523d1218844922868497c483e5836132804c9a9 CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46710/42886/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 12499 lines from the logs
• Reco comparison results: 382 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343764
• DQMHistoTests: Total failures: 1461
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3342283
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 1 / 44 workflows

[mmusich]

type egamma, bug-fix

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1