search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Minor updates to AlpakaCore README #46711

Closed makortel closed 5 days ago

makortel commented 6 days ago

PR description:

The use of return std::move(...) in the ESProducer examples caught my eye, as the use of std::move() there has usually resulted in "pessimizing move" warnings (can't remember if from compiler or from clang-tidy). None of the test code in HeterogeneousCore/AlpakaTest uses std::move() in conjunction with return, so I think it is good to remove it from the example.

This also fixes one link.

Resolves https://github.com/cms-sw/framework-team/issues/1091

PR validation:

None

cmsbuild commented 6 days ago

cms-bot internal usage

cmsbuild commented 6 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46711/42669

cmsbuild commented 6 days ago

A new Pull Request was created by @makortel for master.

It involves the following packages:

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. @missirol, @rovere this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel commented 6 days ago

@cmsbuild, please test

cmsbuild commented 6 days ago

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9e1d/42889/summary.html COMMIT: 125c8927a81d78723e1fa79da329c6b3737799cc CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46711/42889/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

fwyzard commented 6 days ago

+1

On Fri, 15 Nov 2024, 23:22 cmsbuild, @.***> wrote:

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9e1d/42889/summary.html COMMIT: 125c892 https://github.com/cms-sw/cmssw/commit/125c8927a81d78723e1fa79da329c6b3737799cc CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/ cms-ci.cern.ch/week1/cms-sw/cmssw/46711/42889/install.sh to create a dev area with all the needed externals and cmssw changes. Comparison Summary

Summary:

— Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmssw/pull/46711#issuecomment-2480040830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7BTIM3TFNYITJLYV7WCXL2AZX25AVCNFSM6AAAAABR3YXG3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGA2DAOBTGA . You are receiving this because you were mentioned.Message ID: @.***>

cmsbuild commented 6 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 5 days ago

+1