Release memory earlier in PFBlockProducer

Dr15Jones commented 6 days ago

PR description:

Using an experimental AllocMonitor service showed that PFBlockProducer was holding additional memory between events which was often then resized.

PR validation:

A simple test using step3 of workflow 1330.0 showed that per event memory retention was eliminated.

Dr15Jones commented 6 days ago

please test

cmsbuild commented 6 days ago

cms-bot internal usage

cmsbuild commented 6 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46712/42670

cmsbuild commented 6 days ago

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

CommonTools/RecoAlgos (reconstruction)
RecoParticleFlow/PFProducer (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @abbiendi, @ahinzmann, @gkasieczka, @hatakeyamak, @jdolen, @jhgoh, @lgray, @missirol, @mmarionncern, @rappoccio, @seemasharmafnal this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 6 days ago

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-371f2e/42891/summary.html COMMIT: 8a23583fe2646682592133bdae42163013174c36 CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46712/42891/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343764
DQMHistoTests: Total failures: 490
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343254
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

jfernan2 commented 4 days ago

+1

cmsbuild commented 4 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 3 days ago

+1

cms-sw / cmssw