Move module event service signals to include ~Event

Dr15Jones commented 6 days ago

PR description:

The per event module level service signals now happen after the edm::Event is destroyed. This allows accomodating for temporary memory use seen by the AllocMonitors.

PR validation:

Tested with an experimental AllocMonitor that noticed the destruction of temporary View related data during ~Event.

Dr15Jones commented 6 days ago

please test

cmsbuild commented 6 days ago

cms-bot internal usage

cmsbuild commented 6 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46713/42671

cmsbuild commented 6 days ago

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

FWCore/Framework (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. @makortel, @missirol, @wddgit this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 6 days ago

+1

Size: This PR adds an extra 36KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f967a6/42892/summary.html COMMIT: e3989594c02937cd1f2325d9e85ecf8be16cf5ce CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46713/42892/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343764
DQMHistoTests: Total failures: 486
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343258
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

makortel commented 3 days ago

Comparison differences are related to https://github.com/cms-sw/cmssw/issues/46416

makortel commented 3 days ago

+core

cmsbuild commented 3 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 3 days ago

+1

cms-sw / cmssw