search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

Introduce `SiStripNoisesGetAllChecker` #46714

Closed mmusich closed 1 week ago

mmusich commented 1 week ago

PR description:

The goal of this PR is to add a utility plugin SiStripNoisesGetAllChecker, which is meant to check that SiStripNoise is available for all strips defined within the module geometric boundaries. This class was useful in the debugging of https://github.com/cms-sw/cmssw/issues/43078.

PR validation:

Relies on the unit tests of the package scram b runtests_testCondToolsSiStripBuildersReaders runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46714/42674

Code check has found code style and quality issues which could be resolved by applying following patch(s)

cmsbuild commented 1 week ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46714/42675

cmsbuild commented 1 week ago

A new Pull Request was created by @mmusich for master.

It involves the following packages:

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks. @JanChyczynski, @PonIlya, @VinInn, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich commented 1 week ago

@cmsbuild, please test

cmsbuild commented 1 week ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f54f6/42900/summary.html COMMIT: ab0ae723ee49612ad53670172ef2819de9cc3110 CMSSW: CMSSW_14_2_X_2024-11-16-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46714/42900/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

perrotta commented 1 week ago

+db

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1