Remove legacy L1T digis dependencies in Online DQM

[mmusich]

PR description:

In the ticket CMSALCAFAST-94, while testing a new Global Tag candidate meant for a general cleaning of unused / previous runs unmaintained records, few online DQM clients (dt4ml, dt, ecal, and hlt) encountered issues and failed. The reason of these failures was analyzed as unnecessary dependencies of the current DQM clients on the legacy L1T digis. This is fixed / worked around in this PR.

• 9b3afd7e478fd1ec4b0b66f876e1188754feab27 removes the dependency in HLTSiStripMonitorCluster by means of re-configuring the few instances of GenericTriggerEventFlag class to use the stage 2 gt digis in presence of the stage2L1Trigger modifier.
• 8c7fd9b32506c8450f6734d9201da13714317043 replaces the legacy gt digis with the stage2 ones in presence of the stage2L1Trigger modifier
• fe46246e44fbac0a69747078acf9ac64a72d68e1 works around the fact that the DQM/EcalMonitorTasks/src/ClusterTask.cc natively doesn't support the stage2 L1T setup but requires products from the legacy L1T (this is followed up also at https://github.com/cms-sw/cmssw/issues/46715)

PR validation:

The following commands work with this branch,

scram b runtests_TestDQMOnlineClient-hlt_dqm_sourceclient use-ibeos
scram b runtests_TestDQMOnlineClient-dt_dqm_sourceclient use-ibeos
scram b runtests_TestDQMOnlineClient-dt4ml_dqm_sourceclient use-ibeos
scram b runtests_TestDQMOnlineClient-ecal_dqm_sourceclient use-ibeos

when tested by using the Global Tag proposed at CMSALCAFAST-94.

diff --git a/DQM/Integration/python/config/FrontierCondition_GT_cfi.py b/DQM/Integration/python/config/FrontierCondition_GT_cfi.py
index 5845afa34bb..a91ce205422 100644
--- a/DQM/Integration/python/config/FrontierCondition_GT_cfi.py
+++ b/DQM/Integration/python/config/FrontierCondition_GT_cfi.py
@@ -1,7 +1,7 @@
 import FWCore.ParameterSet.Config as cms
 from Configuration.StandardSequences.FrontierConditions_GlobalTag_cff import *
 from Configuration.AlCa.autoCond import autoCond
-GlobalTag.globaltag = autoCond['run3_hlt']
+GlobalTag.globaltag = "141X_dataRun3_HLT_Candidate_2024_11_15_CleaningOfRecords"  #autoCond['run3_hlt']

 #############################################
 #

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46716/42676

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DQM/Integration/python/clients/dt4ml_dqm_sourceclient-live_cfg.py modified in PR(s): #46662
  • File DQM/Integration/python/clients/dt_dqm_sourceclient-live_cfg.py modified in PR(s): #46662
  • File DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py modified in PR(s): #46076, #46662

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46716/42676/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46716/42676/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46716/42677

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DQM/Integration/python/clients/dt4ml_dqm_sourceclient-live_cfg.py modified in PR(s): #46662
  • File DQM/Integration/python/clients/dt_dqm_sourceclient-live_cfg.py modified in PR(s): #46662
  • File DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py modified in PR(s): #46076, #46662

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• DQM/DTMonitorModule (dqm)
• DQM/EcalMonitorTasks (dqm)
• DQM/Integration (dqm)
• DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. @Fedespring, @HuguesBrun, @ReyerBand, @argiro, @batinkov, @battibass, @cericeci, @francescobrivio, @jhgoh, @missirol, @mtosi, @rchatter, @rociovilar, @thomreis, @threus, @trocino, @wang0jin this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad70ba/42901/summary.html COMMIT: fe46246e44fbac0a69747078acf9ac64a72d68e1 CMSSW: CMSSW_14_2_X_2024-11-16-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46716/42901/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343764
• DQMHistoTests: Total failures: 565
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343179
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[antoniovagnerini]

+1

• spurious differences from HGCal DQM test (open issue #46416)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1