search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

[UBSAN][L1]Properly initialize data members #46718

Closed smuzaffar closed 2 days ago

smuzaffar commented 4 days ago

This should fix the UBSAN runtime errors [a]

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/raw/el8_amd64_gcc12/CMSSW_14_2_UBSAN_X_2024-11-15-2300/pyRelValMatrixLogs/run/23634.0_TTbar_14TeV+Run4D95/step2_TTbar_14TeV+Run4D95.log

23634.0/step2:L1Trigger/TrackFindingTracklet/interface/TrackletEngineUnit.h:28:9: runtime error: load of value 155, which is not a valid value for type 'bool'
23634.0/step2:L1Trigger/TrackFindingTracklet/interface/TrackletEngineUnit.h:28:9: runtime error: load of value 80, which is not a valid value for type 'bool'
23634.0/step2:L1Trigger/TrackFindingTracklet/interface/TrackletEngineUnit.h:28:9: runtime error: load of value 194, which is not a valid value for type 'bool'
23634.0/step2:L1Trigger/TrackFindingTracklet/interface/MatchEngineUnit.h:28:9: runtime error: load of value 9, which is not a valid value for type 'bool'
23634.0/step2:L1Trigger/TrackFindingTracklet/interface/MatchEngineUnit.h:28:9: runtime error: load of value 155, which is not a valid value for type 'bool'
23634.0/step2:L1Trigger/TrackFindingTracklet/interface/MatchEngineUnit.h:28:9: runtime error: load of value 208, which is not a valid value for type 'bool'
cmsbuild commented 4 days ago

cms-bot internal usage

smuzaffar commented 4 days ago

test parameters:

cmsbuild commented 4 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46718/42681

cmsbuild commented 4 days ago

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. @Martin-Grunewald, @erikbutz, @missirol, @mmusich, @skinnari this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar commented 4 days ago

please test

smuzaffar commented 4 days ago

please test for CMSSW_14_2_UBSAN_X

cmsbuild commented 4 days ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-189403/42910/summary.html COMMIT: 34a2c7b5e56c9a5eddab3b926197549b2f87938b CMSSW: CMSSW_14_2_UBSAN_X_2024-11-15-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46718/42910/install.sh to create a dev area with all the needed externals and cmssw changes.

cmsbuild commented 4 days ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-189403/42909/summary.html COMMIT: 34a2c7b5e56c9a5eddab3b926197549b2f87938b CMSSW: CMSSW_14_2_X_2024-11-17-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46718/42909/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

aloeliger commented 3 days ago

+l1

cmsbuild commented 3 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 2 days ago

+1