search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Improvements for `SubmitPVsplit` unit test #46719

Closed mmusich closed 3 days ago

mmusich commented 4 days ago

PR description:

This PR is an attempt to solve part of issue https://github.com/cms-sw/cmssw/issues/45751 related to the SubmitPVsplit unit test (see also IB logs).

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cmsbuild commented 4 days ago

cms-bot internal usage

cmsbuild commented 4 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46719/42682

cmsbuild commented 4 days ago

A new Pull Request was created by @mmusich for master.

It involves the following packages:

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. @adewit, @mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich commented 4 days ago

please test for CMSSW_14_2_ASAN_X

cmsbuild commented 4 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46719/42683

cmsbuild commented 4 days ago

Pull request #46719 was updated. @atpathak, @cmsbuild, @consuegs, @perrotta can you please check and sign again.

mmusich commented 4 days ago

please test for CMSSW_14_2_ASAN_X

cmsbuild commented 4 days ago

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bcdaa/42912/summary.html COMMIT: db24ba3854ce41ee78b0fcf07a35cc5f7b265583 CMSSW: CMSSW_14_2_ASAN_X_2024-11-15-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46719/42912/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bcdaa/42912/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bcdaa/42912/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_22_setup had ERRORS
---> test test_MC_23_setup had ERRORS
mmusich commented 4 days ago

Unit test SubmitPVsplit completed successfully see log.

mmusich commented 4 days ago

@cmsbuild, please test

cmsbuild commented 3 days ago

+1

Size: This PR adds an extra 28KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bcdaa/42917/summary.html COMMIT: db24ba3854ce41ee78b0fcf07a35cc5f7b265583 CMSSW: CMSSW_14_2_X_2024-11-17-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46719/42917/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

perrotta commented 3 days ago

+alca

cmsbuild commented 3 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 3 days ago

+1