search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

ZDC Phase2 HcalTPChannelParameters update to silence multiple warnings #46721

Closed abdoulline closed 3 days ago

abdoulline commented 4 days ago

PR description:

Complementary to Sunanda's just submitted https://github.com/cms-sw/cmssw/pull/46720 Silences 18 warnings at beginRun mentioned earlier by @mmusich

PR validation:

wf 29634.0 runs without warnings

cmsbuild commented 4 days ago

cms-bot internal usage

cmsbuild commented 4 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46721/42691

cmsbuild commented 4 days ago

A new Pull Request was created by @abdoulline for master.

It involves the following packages:

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. @bsunanda, @mariadalfonso, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

perrotta commented 3 days ago

please test

cmsbuild commented 3 days ago

-1

Failed Tests: RelVals Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f9d62/42919/summary.html COMMIT: f7d5f834ce9f3c8b47b653410cdd7e2d1190d8eb CMSSW: CMSSW_14_2_X_2024-11-17-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46721/42919/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

perrotta commented 3 days ago

@smuzaffar I can't see the link to the "Comparisons failed" in these latest PR tests: is it due to the failing RelVals in those tests? Even if the errors are evidently unrelated DAS errors, as in this case? See also https://github.com/cms-sw/cmssw/pull/46719#issuecomment-2481536266

smuzaffar commented 3 days ago

yes @perrotta when there are relval errors then bot does not run comparison job

perrotta commented 3 days ago

please test (let retry, then)

cmsbuild commented 3 days ago

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f9d62/42937/summary.html COMMIT: f7d5f834ce9f3c8b47b653410cdd7e2d1190d8eb CMSSW: CMSSW_14_2_X_2024-11-18-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46721/42937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

perrotta commented 3 days ago

+1

cmsbuild commented 3 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 3 days ago

+1