update a vertex smearing parameters for 2024 PbPb MC

ashleyahram commented 3 days ago

PR description:

This PR adds a vertex smearing for 2024 PbPb MC. Beamspot position derived from runs 387998 to 388425, BPIX barycentre location obtained from TrackerAlignment_PCL_byRun_v2_express, official BPIX value will be provided by Tracker Alignment Group soon (cmsTalk)

PR validation:

This PR has been modeled after a similar PR from 2022, 2023, and 2024: https://github.com/cms-sw/cmssw/pull/40496, https://github.com/cms-sw/cmssw/pull/43217, https://github.com/cms-sw/cmssw/pull/46639

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We will need a backport for 14_1_X

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild commented 3 days ago

cms-bot internal usage

cmsbuild commented 3 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46723/42694

cmsbuild commented 3 days ago

A new Pull Request was created by @ashleyahram for master.

It involves the following packages:

Configuration/StandardSequences (operations)
IOMC/EventVertexGenerators (simulation)

@antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @grzanka, @makortel, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

civanch commented 3 days ago

please test

cmsbuild commented 3 days ago

+1

Size: This PR adds an extra 28KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ef200/42938/summary.html COMMIT: acb6f193930670ae6beb9c91d7bcf833d8114442 CMSSW: CMSSW_14_2_X_2024-11-18-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46723/42938/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3344340
DQMHistoTests: Total failures: 441
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343879
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

civanch commented 2 days ago

+1

mandrenguyen commented 2 days ago

+1

cmsbuild commented 2 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cms-sw / cmssw