search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Fixed energy of R-Hadron cloud in energy deposit model #46728

Closed ctdax closed 1 day ago

ctdax commented 3 days ago

PR description:

A 2015 commit to FullModelHadronicProcess.cc introduced a bug to the energy deposit model. This bug incorrectly deposited energy values close to the BSM particles mass into the simulated detector. This merge request reverts the energy deposit model to a previously working version from 2015. This is a work in progress, additional changes are expected to be made. Here are slides given to the EXO general group on the topic from November 19th, 2024

PR validation:

scram b runtests use-ibeos completed successfully. runTheMatrix.py -l limited -i all --ibeos completed successfully without any failrues. Below is a comparison of 10,000 identically seeded simulated energy deposits in the ECAL barrel with and without the bug.

Screenshot 2024-11-18 at 1 51 38 PM Screenshot 2024-11-18 at 1 52 19 PM
cmsbuild commented 3 days ago

cms-bot internal usage

cmsbuild commented 3 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46728/42698

cmsbuild commented 3 days ago

A new Pull Request was created by @ctdax for master.

It involves the following packages:

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. @bsunanda, @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

civanch commented 2 days ago

please test

civanch commented 2 days ago

Let us test this PR

cmsbuild commented 2 days ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91c699/42947/summary.html COMMIT: 0ade249ea849d38d9ae2fe4e51392d89dae4b54a CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46728/42947/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

civanch commented 1 day ago

please test

cmsbuild commented 1 day ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91c699/42980/summary.html COMMIT: 0ade249ea849d38d9ae2fe4e51392d89dae4b54a CMSSW: CMSSW_14_2_X_2024-11-20-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46728/42980/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

civanch commented 1 day ago

+1

cmsbuild commented 1 day ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

civanch commented 1 day ago

@ctdax , I think that it is OK to merge this fix, further fixes/improvements may be in the next PRs. One thing I would recommend: please, substitute "Work in progress! Updated to" in the title by "Fixed energy of R-Hadron cloud in ". Edition of the title or description will no trigger new tests, precise title is usefull in the long term.

Depending on what Run period is considered for the analysis, backport(s) will be needed. If you foresee extra PRs on this subject, the backport may be the sum of all done for the master. If you are not sure, better to backport what is proposed in this PR now and do not postpond this.

mandrenguyen commented 1 day ago

+1

mandrenguyen commented 1 day ago

@ctdax , I think that it is OK to merge this fix, further fixes/improvements may be in the next PRs. One thing I would recommend: please, substitute "Work in progress! Updated to" in the title by "Fixed energy of R-Hadron cloud in ". Edition of the title or description will no trigger new tests, precise title is usefull in the long term.

I went ahead and took care of the title change. Please let me know if I did not follow the suggestion correctly.