[14.1.X] `SiStripZeroSupperssion`: discard processing unphysical clusters in `suppressHybridData`

[mmusich]

backport of https://github.com/cms-sw/cmssw/pull/46722

PR description:

This PR is meant as a patch for the issue described at https://github.com/cms-sw/cmssw/issues/43078, where the fix consists simply in discarding the APVs in which the request of the strip number is higher than the maximum allowed in the module.

• 2e37ec281fb820b0d3568248dbd5ec576d77baa5: adds a utility method to SiStripDetId that returns if the underlying Strip module is connected to 4 or 6 APVs.
• 7f5283ea1fada44eda4efdbef9f0b5f49d356bb0: discard strip digi payloads with unphysical numer of strips in processHybrid, using SiStripDetId::numberOfAPVs().

PR validation:

Run the following script:

#!/bin/bash -ex

# CMSSW_14_1_5_patch1       

hltGetConfiguration run:388419 \
  --globaltag 141X_dataRun3_HLT_v1 \
  --data \
  --no-prescale \
  --no-output \
  --max-events -1 \
  --input file:converted.root  > hlt.py

# Define a function to execute each iteration of the loop
process_file() {
    inputfile="$1"
    outputfile="${inputfile%.root}"
    cp hlt.py hlt_${outputfile}.py
    sed -i "s/file:converted\.root/\/store\/group\/tsg\/FOG\/error_stream_root\/run388419\/${inputfile}/g" hlt_${outputfile}.py
    cmsRun hlt_${outputfile}.py &> "${outputfile}.log"
}

# Export the function so it can be used by parallel
export -f process_file

# Find the root files and run the function in parallel using GNU Parallel
eos ls /eos/cms/store/group/tsg/FOG/error_stream_root/run388419/ | grep '\.root$' | parallel -j 4 process_file

which runs over the list of error stream files from run-388419 (elog/1247892) where we had in excess of 1k HLT crashes, and didn't observe residual crashes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of https://github.com/cms-sw/cmssw/pull/46722 for HLT online operations during the 2024 PbPb run.

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

• DataFormats/SiStripDetId (simulation)
• RecoLocalTracker/SiStripClusterizer (reconstruction)
• RecoLocalTracker/SiStripZeroSuppression (reconstruction)

@civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @VinInn, @VourMa, @alesaggio, @echabert, @felicepantaleo, @gbenelli, @gpetruc, @jlidrych, @missirol, @mmusich, @mtosi, @robervalwalsh, @rovere, @threus, @yduhm this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from #46722

[cmsbuild]

cms-bot internal usage

[mmusich]

test parameters:

• workflows = 161, 161.02, 161.03, 161.1, 161.2, 161.3, 161.4, 180.0, 180.1, 181, 181.1

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d0761/42941/summary.html COMMIT: 7f5283ea1fada44eda4efdbef9f0b5f49d356bb0 CMSSW: CMSSW_14_1_X_2024-11-18-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46730/42941/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 56
• DQMHistoTests: Total histograms compared: 4827178
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4827147
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 55 files compared)
• Checked 251 log files, 215 edm output root files, 56 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1