search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

[Simulation] Allow DT ageing toy model to run at the DIGI-L1T step #46732

Open battibass opened 2 days ago

battibass commented 2 days ago

PR description:

This pull request updates the toy model used to account for potential DT cell inefficiencies due to aging, so that it can be applied at the digitization step. This allows for a consistent impact on simulated digis before packing and trigger-primitive generation.

PR validation:

To be applied, DT aging a customization function should be used, no effect is expected in standard workflows.

Local testing was performed by adding the customization function in the step2 of runTheMatrix.py -w upgrade 12809.0 and analyzing the produced samples.Results will be presented at the Simulation meeting

cmsbuild commented 2 days ago

cms-bot internal usage

cmsbuild commented 2 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46732/42702

cmsbuild commented 2 days ago

A new Pull Request was created by @battibass for master.

It involves the following packages:

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. @jhgoh, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

civanch commented 2 days ago

please test

cmsbuild commented 2 days ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6018d/42946/summary.html COMMIT: 71fb208b99ca74ebfc85fa0fa322c35777f25cc1 CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46732/42946/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

civanch commented 1 day ago

@battibass , please, have a look into https://github.com/cms-sw/cmssw/blob/master/SLHCUpgradeSimulations/Configuration/python/aging.py#L245-L257 It seems to be the optimal place where aging for DT is enabled.