cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Phase2-hgx360S Update a few constants in v19 hgcal.xml file #46733

Closed bsunanda closed 1 day ago

bsunanda commented 2 days ago

PR description:

Update a few constants in v19 hgcal.xml file

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild commented 2 days ago

cms-bot internal usage

bsunanda commented 2 days ago

@cmsbuild Please test

cmsbuild commented 2 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46733/42703

cmsbuild commented 2 days ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 2 days ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4cf31/42948/summary.html COMMIT: 21e4019f7839661b79f1b269ac7efcafad64c487 CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46733/42948/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

bsunanda commented 2 days ago

+geometry

bsunanda commented 2 days ago

@subirsarkar Please approve this PR

subirsarkar commented 2 days ago

+Upgrade

cmsbuild commented 2 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 day ago

+1