Phase2-hgx360U Update the code for guard ring and mouse bite usage in full and partial wafers in HGCal geometry definition

bsunanda commented 2 days ago

PR description:

Update the code for guard ring and mouse bite usage in full and partial wafers in HGCal geometry definition

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild commented 2 days ago

cms-bot internal usage

cmsbuild commented 2 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46734/42704

cmsbuild commented 2 days ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4CMS/Calo (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. @ReyerBand, @fabiocos, @felicepantaleo, @martinamalberti, @rovere, @slomeo, @thomreis, @wang0jin this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda commented 2 days ago

@cmsbuild Please test

cmsbuild commented 2 days ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3437ac/42949/summary.html COMMIT: 13ff322d4f19eb5e5253e95c2a6c29ca4bde9f88 CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46734/42949/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3344340
DQMHistoTests: Total failures: 422
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343898
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

bsunanda commented 2 days ago

@cmsbuild Please test

cmsbuild commented 1 day ago

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3437ac/42965/summary.html COMMIT: 13ff322d4f19eb5e5253e95c2a6c29ca4bde9f88 CMSSW: CMSSW_14_2_X_2024-11-19-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46734/42965/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3483722
DQMHistoTests: Total failures: 480
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3483222
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

civanch commented 1 day ago

+1

cmsbuild commented 1 day ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 day ago

+1

cms-sw / cmssw