search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

[14_1_X] Temporary Rollback for DIP BeamSpot client #46736

Open francescobrivio opened 5 days ago

francescobrivio commented 5 days ago

PR description:

As reported on Mattermost (here) there is an issue with the publication of the online BeamSpot to DIP (and consequently to OMS) since online DQM was switched to CMSSW_14_1_patch1.

In this PR I'm temporarily rolling-back the changes introduced in https://github.com/cms-sw/cmssw/pull/46614, i.e. we go back to reading the default input file BeamFitResults.txt instead of BeamFitResultsForDIP.txt which is in the wrong format, hence causing the DIP publication issue.

Since we have only ~1 week of data-taking left in 2024, the correct implementation will come for 2025 data-taking.

PR validation:

To be tested at P5.

Backport:

Given the urgency I'm opening the 14_1_X PR first and will take care later of the master PR. EDIT: backport of #46737

cmsbuild commented 5 days ago

A new Pull Request was created by @francescobrivio for CMSSW_14_1_X.

It involves the following packages:

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. @batinkov, @threus this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 5 days ago

cms-bot internal usage

francescobrivio commented 5 days ago

urgent

francescobrivio commented 5 days ago

@cmsbuild please test

francescobrivio commented 5 days ago

backport of https://github.com/cms-sw/cmssw/pull/46737

cmsbuild commented 5 days ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d6859/42953/summary.html COMMIT: abc54ca8b1db0f7249a79034737ea91fcdf7f28f CMSSW: CMSSW_14_1_X_2024-11-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46736/42953/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

antoniovagnerini commented 5 days ago

+1

cmsbuild commented 5 days ago

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovagnerini commented 5 days ago

backport of https://github.com/cms-sw/cmssw/pull/46737