search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Temporary Rollback for DIP BeamSpot client #46737

Closed francescobrivio closed 1 day ago

francescobrivio commented 2 days ago

PR description:

This PR is a "forwardport" of https://github.com/cms-sw/cmssw/pull/46736 Original description:

As reported on Mattermost (here) there is an issue with the publication of the online BeamSpot to DIP (and consequently to OMS) since online DQM was switched to CMSSW_14_1_patch1.

In this PR I'm temporarily rolling-back the changes introduced in https://github.com/cms-sw/cmssw/pull/46614, i.e. we go back to reading the default input file BeamFitResults.txt instead of BeamFitResultsForDIP.txt which is in the wrong format, hence causing the DIP publication issue.

Since we have only ~1 week of data-taking left in 2024, the correct implementation will come for 2025 data-taking.

PR validation:

14_1_X backport to be tested in P5

Backport:

Not a backport. 14_1_X backport provided in #46736

cmsbuild commented 2 days ago

cms-bot internal usage

cmsbuild commented 2 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46737/42707

cmsbuild commented 2 days ago

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. @batinkov, @threus this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

antoniovagnerini commented 2 days ago

please test

cmsbuild commented 2 days ago

-1

Failed Tests: RelVals Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a115/42954/summary.html COMMIT: cced5081c0b057aa644da2826e0cfea1db5a9871 CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46737/42954/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

antoniovagnerini commented 2 days ago

please test

cmsbuild commented 1 day ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a115/42964/summary.html COMMIT: cced5081c0b057aa644da2826e0cfea1db5a9871 CMSSW: CMSSW_14_2_X_2024-11-19-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46737/42964/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

antoniovagnerini commented 1 day ago

+dqm

cmsbuild commented 1 day ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 day ago

+1