Improvements for HCAL LUT XML Diffing

JHiltbrand commented 2 days ago

PR description:

This PR concerns some improvements to HCAL LUT XML comparing. Note that HCAL LUT XML generation/diffing code is run manually offline and not a part of standard workflows. The only regularly-used "mainline" code that is modified for this PR is HcaluLUTTPGCoder and HcalTPGCoderULUT. This is due to a single function call, which now requires an HcalElectronicsEmap pointer, as the function is depended upon in the LUT XML gen/diff code. The including of HcalElectronicsMap pointer in these two classes is accommodated in the same way that they are passed a topology and time slew pointer at construction time.

Notable changes introduced in this PR:

Explicitly show ZDC in LUT XML diffing
Split results by zside in addition to showing total for each HCAL subdetector i.e. HBP, HBM, HB, etc.
Fix check of fine-grain (FG) bits in HBHE and introduce check for HF FG
Make use of HcalElectronicsEmap via DB conditions in order scary subdet_from_crate hard-coding
Move diff module from standalone executable and make it an EDAnalyzer to have native access to HcalElectronicsMap

PR validation:

A XML LUT was generated with and without the PR and with intentional input conditions differences. With the PR, the LUT diff finds the same number of HCAL channels for the various subdetectors and show ZDC channels, along with expected differences based on input conditions differences.

ATTN: @hjbossi @abdoulline @akhukhun

cmsbuild commented 2 days ago

cms-bot internal usage

cmsbuild commented 2 days ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46738/42708

cmsbuild commented 2 days ago

A new Pull Request was created by @JHiltbrand for master.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos (alca, l1)
CalibCalorimetry/HcalTPGEventSetup (alca, l1)
CaloOnlineTools/HcalOnlineDb (db)

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks. @JanChyczynski, @PonIlya, @abdoulline, @bsunanda, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

aloeliger commented 2 days ago

please test

cmsbuild commented 2 days ago

+1

Size: This PR adds an extra 44KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d57394/42961/summary.html COMMIT: 0dde070885c5d388ffa854dbd4fae9bfb9ad9a58 CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46738/42961/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3344340
DQMHistoTests: Total failures: 491
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343829
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

perrotta commented 1 day ago

+1

cms-sw / cmssw