cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

[RFC] Using main cmssw repository for L1Tracking development #46748

Open iarspider opened 1 day ago

iarspider commented 1 day ago

As discussed during yesterday's Core Software meeting, we propose the following solution for better integration of L1Tracking development in CMSSW:

This way, when a PR is opened that changes files under these packages, only the relevant experts will be notified, and their signature will be required to merge the PR.

@tomalin FYI

cmsbuild commented 1 day ago

cms-bot internal usage

cmsbuild commented 1 day ago

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

smuzaffar commented 1 day ago

thanks @iarspider for opening this issue.

These packages currently are in l1 category, we can move them out

The should remain under l1. We just add these packages under new l1track too

smuzaffar commented 1 day ago

type doc

smuzaffar commented 1 day ago

Add special tests (similar to, e.g., gpu) that can be requested in addition to regular tests

@tomalin , for additional l1track tests, we need to teach bot how to recognize it and what to run. You can see https://github.com/cms-sw/cms-bot/pull/2354 and https://github.com/cms-sw/cms-bot/pull/2240 as examples for running enable and run extra PR test. @cms-sw/externals-l2 can take care of it if you point us your current test ( run via gitlab ci) Or feel free to open cms-bot PR

makortel commented 1 day ago

assign l1

cmsbuild commented 1 day ago

New categories assigned: l1

@aloeliger,@epalencia you have been requested to review this Pull request/Issue and eventually sign? Thanks