cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Updated Input tags and code additions for TOP Production DQM GEN-SIM-RECO #46749

Open dsidirop1 opened 1 day ago

dsidirop1 commented 1 day ago

Description of PR

  1. the update from <reco::PFCandidate> objects which are obsolete to f.e. <reco::Muon>, <reco::GsfElectron> per the relevant objects found in the input files used.
  2. The update of selection cuts structure to remove unnecessary references and dependencies e.g. mediumMuonCut = looseMuonCut + " muonRef.innerTrack.validFraction > 0.8" becomes mediumMuonCut = looseMuonCut + " innerTrack.validFraction > 0.8".
  3. Some unnecessary checks in loops like:
    if (muonit->muonRef().isNull())
        continue;
      reco::MuonRef muon = muonit->muonRef();

    in TopSingleLeptonDQM.cc were removed completely.

  4. Histograms for jets 3 and 4 were added to SingleTopTChannelLeptonDQM.cc for completion purposes and to align it with the TopSingleLeptonDQM.cc analysis.
  5. Certain comments that were not useful or obsolete were removed to make the code more conscise.

PR validation:

Changes have been made to the following files:

To verify the results of the aforementioned actions the file DQM/Physics/test/topDQM_production_cfg.py was executed with cmsRun to produce a .root file that was then used as input for the DQM/Physics/test/topDQM_harvesting_cfg.py to produce a tree with the relevant histograms needed that were browsed using the TBrowser root feature. As evidence of the success of the task two of those histograms (one from TopSingleMuonMediumDQM and the other from SingleTopElectronMediumDQM) are attached on this PR.

TopSingleMuonMediumDQM_step1_Jet1Pt SingleTopElectronMediumDQM_step2_METPflow

cmsbuild commented 1 day ago

cms-bot internal usage

cmsbuild commented 1 day ago

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42720

Code check has found code style and quality issues which could be resolved by applying following patch(s)

cmsbuild commented 21 hours ago

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42727

Code check has found code style and quality issues which could be resolved by applying following patch(s)

cmsbuild commented 13 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42737

cmsbuild commented 13 hours ago

A new Pull Request was created by @dsidirop1 for master.

It involves the following packages:

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. @rappoccio this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here