RecoMTD: new class for storing variables for BTD and GNN training

kdeleo commented 20 hours ago

PR description:

This PR adds a new class to RecoMTD/TimingIDTools that stores the variables used for the training of the MTD track quality BDT and for the training of the vertex clustering GNN.

Presentation on BDT at MTD DPG:

https://indico.cern.ch/event/1475908/#4-status-of-mtd-track-quality

Presentations on GNN at MTD DPG:

PR validation:

Example configuration added in test/mvaTrainingSaveNtuple_cfg.py

cmsbuild commented 20 hours ago

cms-bot internal usage

cmsbuild commented 20 hours ago

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46751/42728

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46751/42728/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46751/42728/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild commented 19 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46751/42729

cmsbuild commented 19 hours ago

A new Pull Request was created by @kdeleo for master.

It involves the following packages:

RecoMTD/TimingIDTools (reconstruction, upgrade)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti, @missirol this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

fabiocos commented 19 hours ago

please test

fabiocos commented 19 hours ago

type mtd

cmsbuild commented 16 hours ago

+1

Size: This PR adds an extra 32KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e27564/42983/summary.html COMMIT: 3cb9bd70356ec93c8fad5aa537199583c8723984 CMSSW: CMSSW_14_2_X_2024-11-20-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46751/42983/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3483722
DQMHistoTests: Total failures: 527
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3483175
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

cms-sw / cmssw