search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

MTD reconstruction: save correct outermost hit position also for tracks w/o last hit in mtd #46752

Open martinamalberti opened 19 hours ago

martinamalberti commented 19 hours ago

PR description:

This PR implement a fix of the outermost hit position value, saved by the TrackExtenterWithMTD class, for tracks w/o last hit in MTD.

PR validation:

The code compiles, runs and produces expected results. Tested on workflow 29607.0.

cmsbuild commented 19 hours ago

cms-bot internal usage

cmsbuild commented 19 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46752/42730

cmsbuild commented 19 hours ago

A new Pull Request was created by @martinamalberti for master.

It involves the following packages:

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @missirol this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

jfernan2 commented 17 hours ago

enable profiling

jfernan2 commented 17 hours ago

please test

cmsbuild commented 12 hours ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-119d70/42986/summary.html COMMIT: 550e9be8bdbc181a9f66297eba711e69ee16d883 CMSSW: CMSSW_14_2_X_2024-11-21-1100/el8_amd64_gcc12 Additional Tests: PROFILING User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46752/42986/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

fabiocos commented 16 minutes ago

please test

all failures in previous test look unrelated to this PR