search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Phase2-hgx360W Provide a method in HGCALDDDConst to access the area of a cell #46753

Open bsunanda opened 18 hours ago

bsunanda commented 18 hours ago

PR description:

Provide a method in HGCALDDDConst to access the area of a cell

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild commented 18 hours ago

cms-bot internal usage

cmsbuild commented 18 hours ago

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46753/42731

Code check has found code style and quality issues which could be resolved by applying following patch(s)

cmsbuild commented 18 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46753/42732

cmsbuild commented 18 hours ago

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda commented 18 hours ago

@cmsbuild Please test

cmsbuild commented 15 hours ago

-1

Failed Tests: UnitTests Size: This PR adds an extra 36KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c1cbc/42984/summary.html COMMIT: adea7fd30010e38406c641084799f5a8fec3222a CMSSW: CMSSW_14_2_X_2024-11-20-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46753/42984/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

bsunanda commented 14 hours ago

@cmsbuild Please test

cmsbuild commented 12 hours ago

-1

Failed Tests: UnitTests RelVals RelVals-INPUT Size: This PR adds an extra 36KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c1cbc/42993/summary.html COMMIT: adea7fd30010e38406c641084799f5a8fec3222a CMSSW: CMSSW_14_2_X_2024-11-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46753/42993/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

RelVals

RelVals-INPUT