Avoid using past module for python2/3 compatibility

[smuzaffar]

We were using past python2/3 compatibility to support both py2 and py3. As CMSSW stack is python3 only so this PR proposes to drop the use of past.

• from past.builtins import long : use long=int as https://github.com/PythonCharmers/python-future/blob/master/src/past/types/__init__.py#L26 was doing
• from past.utils import old_div: We can either use floor division operator // everywhere or just add our own old_div which does the same.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46754/42733

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/ParameterSet/python/Types.py modified in PR(s): #45216

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• FWCore/ParameterSet (core)
• FWCore/PythonUtilities (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. @makortel, @missirol, @wddgit this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

• from past.builtins import long : use long=int as https://github.com/PythonCharmers/python-future/blob/master/src/past/types/__init__.py#L26 was doing
• from past.utils import old_div: We can either use floor division operator // everywhere or just add our own old_div which does the same.

I think this is ok, although eventually it would be nice to "modernize" the code itself to use int, bool, and // directly.

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests Size: This PR adds an extra 36KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5ff10/42989/summary.html COMMIT: 8864274426361a54dd7b13f4edcf3585bc55fd03 CMSSW: CMSSW_14_2_X_2024-11-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46754/42989/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 487
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3483215
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 1 / 44 workflows

[makortel]

Comparison differences are related to https://github.com/cms-sw/cmssw/issues/46416

[makortel]

Unit test failure is https://github.com/cms-sw/cmssw/issues/46682

[makortel]

+core

[makortel]

ignore tests-rejected with ib-failure

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1