search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

avoid holding memory between events in Multi5x5ClusterProducer #46756

Open Dr15Jones opened 14 hours ago

Dr15Jones commented 14 hours ago

PR description:

The holding and then clearing of memory across events was found by a prototype Alloc Monitor service.

NOTE: the only reason I could not change Multi5x5ClusterProducer to be a global module was the use of PositionCalc in Multi5x5ClusterAlgo.

PR validation:

Code compiles and running a very simple RECO job succeeded.

This is purely a refactoring so should not affect any physics results.

Dr15Jones commented 14 hours ago

@makortel FYI

cmsbuild commented 14 hours ago

cms-bot internal usage

cmsbuild commented 14 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46756/42735

cmsbuild commented 14 hours ago

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @argiro, @jainshilpi, @lgray, @missirol, @ram1123, @rchatter, @rovere, @sameasy, @sobhatta, @thomreis, @valsdav, @varuns23, @wang0jin this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones commented 14 hours ago

please test

cmsbuild commented 11 hours ago

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2da7e6/42995/summary.html COMMIT: f55a935922fbb81a5d0d9ffa5344e089d6f93073 CMSSW: CMSSW_14_2_X_2024-11-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46756/42995/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild commented 11 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46756/42738

cmsbuild commented 11 hours ago

Pull request #46756 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

Dr15Jones commented 10 hours ago

please test

cmsbuild commented 7 hours ago

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2da7e6/43001/summary.html COMMIT: c867babe601ef95adddfb278437f9333a46b2921 CMSSW: CMSSW_14_2_X_2024-11-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46756/43001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary: