search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

(HLT) fix service discovery in HLTriggerJSONMonitoring #46760

Open smorovic opened 11 hours ago

smorovic commented 11 hours ago

PR description:

Service template type should not be a pointer. This caused FastMonitoringService service to not be detected and caused output not being suppressed when exception is thrown in HLT.

PR validation:

Modification was tested on replayed error stream data from 2024 HI run and fixes the problem.

cmsbuild commented 11 hours ago

cms-bot internal usage

cmsbuild commented 11 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46760/42742

smorovic commented 11 hours ago

@cmsbuild please test

cmsbuild commented 11 hours ago

A new Pull Request was created by @smorovic for master.

It involves the following packages:

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fwyzard, @missirol, @mmusich, @silviodonato this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 10 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46760/42743

cmsbuild commented 10 hours ago

Pull request #46760 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

smorovic commented 10 hours ago

Actually we can also simplify more and drop writeFiles.

cmsbuild commented 7 hours ago

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

mmusich commented 6 hours ago

@cmsbuild, please test

cmsbuild commented 4 hours ago

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ff1f/43010/summary.html COMMIT: 8f13c7ac82b5727a0f7f2dc651f38a6dabe00f9a CMSSW: CMSSW_14_2_X_2024-11-21-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46760/43010/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary: