search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Class template `edm::IDGeneratorSourceBase<T>` needs some refactoring #46814

Open makortel opened 4 hours ago

makortel commented 4 hours ago

https://github.com/cms-sw/cmssw/pull/46790 added a Source (EmptySourceFromEventIDs) that inherits from edm::IDGeneratorSourceBase<edm::InputSource>, but makes no use of IDGeneratorSourceBase's configuration parameters https://github.com/cms-sw/cmssw/blob/6ac91328dfdd354f105e7584e40d545232627f83/FWCore/Sources/src/IDGeneratorSourceBase.cc#L265-L287

We should refactor edm::IDGeneratorSourceBase<T> such that the configuration parameters above, and all logic related to them, would be separated from the part that EmptySourceFromEventIDs uses.

makortel commented 4 hours ago

assign core

cmsbuild commented 4 hours ago

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 4 hours ago

cms-bot internal usage

cmsbuild commented 4 hours ago

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here